[PATCH v3 1/6] composite: Call ValidateGC after ChangeGC

Ville Syrjälä ville.syrjala at nokia.com
Mon Apr 18 07:40:04 PDT 2011


On Fri, Apr 15, 2011 at 12:17:21PM -0700, ext Jamey Sharp wrote:
> I don't see any on-list discussion about this question: Why does this
> patch also switch from using serverClient to using NullClient?

ChangeGC only uses the client pointer to set client.errorValue if the
changed values are invalid. Pointless in this case, so NullClient is
more appropriate. I think this is the only ChangeGC call that actually
passes in serverClient, all the others pass NullClient, or an actual
client where appropriate.

> Assuming that was intentional, I'd suggest a comment in the commit
> message.

Sure, I'll note in in the commit message.

-- 
Ville Syrjälä


More information about the xorg-devel mailing list