[PATCH evdev] Fix absolute events with swapped axes

Chase Douglas chase.douglas at canonical.com
Wed Dec 14 12:09:23 PST 2011

On 12/14/2011 09:23 AM, przanoni at gmail.com wrote:
> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
> We were correctly swapping the valuator values, but we were not
> calling valuator_mask_unset() when needed, so the cursor kept jumping
> to the edges.
> This patch does the swapping before the main "for", so we don't need to
> store unswapped_{x,y} and unswapped_isset_{x,y} even when we don't need
> to swap.

Would it be better to remove the evdev axis swap property?

If we still want it around, it would probably be easier to have it set
the transformation matrix under the covers. It would make the
transformation matrix and evdev axis swapping properties dependent, but
I doubt anyone is really wanting to mix the two.

-- Chase

More information about the xorg-devel mailing list