[PATCH evdev] Fix absolute events with swapped axes

Peter Hutterer peter.hutterer at who-t.net
Wed Dec 14 20:56:46 PST 2011

On Wed, Dec 14, 2011 at 12:09:23PM -0800, Chase Douglas wrote:
> On 12/14/2011 09:23 AM, przanoni at gmail.com wrote:
> > From: Paulo Zanoni <paulo.r.zanoni at intel.com>
> > 
> > We were correctly swapping the valuator values, but we were not
> > calling valuator_mask_unset() when needed, so the cursor kept jumping
> > to the edges.
> > 
> > This patch does the swapping before the main "for", so we don't need to
> > store unswapped_{x,y} and unswapped_isset_{x,y} even when we don't need
> > to swap.
> Would it be better to remove the evdev axis swap property?
> If we still want it around, it would probably be easier to have it set
> the transformation matrix under the covers. It would make the
> transformation matrix and evdev axis swapping properties dependent, but
> I doubt anyone is really wanting to mix the two.

The problem with "transparent" is it's just that. We could hook into the
property but then those who need swapped axis and their device bound to one
screen only have their configurations break. and if we do it under the
covers, that's only going to be hard to fix.

With the matrix available, all this could be set in client programs but
afaik we don't have any of those yet. so we need to leave this option


More information about the xorg-devel mailing list