[PATCH xserver 14/15] xfree86: use sed rather than cpp to perform string substitutions

Gaetan Nadon memsize at videotron.ca
Sun Jan 9 12:39:53 PST 2011

On Sun, 2011-01-09 at 11:52 -0800, Alan Coopersmith wrote:

> On 01/ 8/11 06:19 PM, Gaetan Nadon wrote:
> > xorgconf.cpp: replaced __xconfigfile__ with xorg.conf as this file name
> > is hard coded in the xserver configuration and cannot change.
> This, and several similar defines/substitutions are leftovers from the
> XFree86->Xorg migration.   When we first created the Xorg server from
> the XFree86 sources, we provided ways to build with the old file names
> for the server & its configuration files, log files, etc. to allow
> distros to switch to the new code base without having to update the
> rest of their code base & documentation to the new names first - their
> installer/configuration utilities could continue to run XFree86 and
> create XF86config files.

Saying "a lot of work" would be an understatement!

> While I know one major distro (the one who contributed the work to use
> the defines to make this possible) was using this 6 years ago, I don't
> think anyone uses it today, and it could probably all go away, though
> I suppose leaving it in preserves an easier ability to fork if someday
> X.Org similarly falls apart as XFree86 and the X Consortia did before it.

I would normally not have touched it as it was not part of my core
but "__xconfigfile__" was already used in other man pages such as
libXxf86vm which draws the text from util-macros MAN_SUBSTS.

Even if the server would change the name, it would remain intact
everywhere else. In the server man pages I would've had to deal with
conflicting substitutions.

Anyway I slice it, something would have to change on the next fork, 
but I won't be around :-)

Thanks for the review, I fixed the typo multiple instances.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110109/84ccf8b0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110109/84ccf8b0/attachment.pgp>

More information about the xorg-devel mailing list