[PATCH xkbcomp 2/2] Fix incorrect processing of char(0xff) in comments
halsmit at t-online.de
Mon Jan 17 02:00:48 PST 2011
On Mon, Jan 17, 2011 at 10:40:18AM +0100, Michel Dänzer wrote:
> On Son, 2011-01-16 at 12:27 +0100, Dirk Wallenstein wrote:
> > On Sun, Jan 16, 2011 at 01:26:10AM +0500, Alexandr Shadchin wrote:
> > > If type readBuf is char, then scanchar() return -1 for char(0xFF) and EOF.
> > > If type readBuf is unsigned char, then scanchar() return 0xFF for char(0xFF)
> > > and -1 for EOF.
> > NAK: I assume you want to correct the case when returning EOF stored
> > inside of readBuf? This would now return EOF as 0x00ff but EOF is a
> > negative value. All parts that access readBuf work with signed values.
> FYI, 'char' on its own may be signed or unsigned depending on the
Ah, I remember (and the gcc options to enforce one). Thanks.
More information about the xorg-devel