[PATCH xkbcomp 2/2] Fix incorrect processing of char(0xff) in comments

Dirk Wallenstein halsmit at t-online.de
Mon Jan 17 11:35:45 PST 2011

On Sun, Jan 16, 2011 at 12:27:30PM +0100, Dirk Wallenstein wrote:
> On Sun, Jan 16, 2011 at 01:26:10AM +0500, Alexandr Shadchin wrote:
> > If type readBuf is char, then scanchar() return -1 for char(0xFF) and EOF.
> > If type readBuf is unsigned char, then scanchar() return 0xFF for char(0xFF)
> > and -1 for EOF.
> NAK: I assume you want to correct the case when returning EOF stored
> inside of readBuf?  This would now return EOF as 0x00ff but EOF is a
> negative value.  All parts that access readBuf work with signed values.

Just in case scanchar() won't get reverted.  This was a misunderstanding
and next time I simply ask.  I guess I meant "Now A Kwestion".
Sorry for the noise.


More information about the xorg-devel mailing list