[PATCH input-synaptics 1/5] Use appropriate Autoconf statements to check for prerequisites

[Dan Nicholson]

On Tue, Jun 14, 2011 at 1:56 AM, Diego Elio Pettenò <flameeyes at gmail.com> wrote:
> Il giorno lun, 13/06/2011 alle 19.43 -0400, Gaetan Nadon ha scritto:
>>
>> Using m4 to check for macro defined by the xserver to ensure it is
>> installed
>> will work as long as the macro is not removed. The preferred way of
>> checking
>> for dependencies is to use PKG_CHECK_MODULE.
>
> Different moment to check for them:
>
> - PKG_CHECK_MODULE check presence when running ./configure
> - m4_ifndef when autoconf is executed.
>
> If you build autotools for the package on a system that has no
> xorg-server installed, you'll receive a broken configure script, thus
> why I wanted to make it explicit that you need to have it around at
> autoconf time.

I'd have to agree here that failing when autoconf is run is better
than creating a broken configure script. Better would be if
xorg-server.m4 defined a version check macro like xorg-macros.m4.

--
Dan