[PATCH input-synaptics 1/5] Use appropriate Autoconf statements to check for prerequisites

[Gaetan Nadon]

On Tue, 2011-06-14 at 10:56 +0200, Diego Elio Pettenò wrote:

> Il giorno lun, 13/06/2011 alle 19.43 -0400, Gaetan Nadon ha scritto:
> > 
> > Using m4 to check for macro defined by the xserver to ensure it is
> > installed
> > will work as long as the macro is not removed. The preferred way of
> > checking
> > for dependencies is to use PKG_CHECK_MODULE. 
> 
> Different moment to check for them:
> 
> - PKG_CHECK_MODULE check presence when running ./configure
> - m4_ifndef when autoconf is executed.
> 
> If you build autotools for the package on a system that has no
> xorg-server installed, you'll receive a broken configure script, thus
> why I wanted to make it explicit that you need to have it around at
> autoconf time.

What is the benefit of having:

        autoreconf: running: aclocal -I /home/nadon/xorg/src/inst/share/aclocal --force 
        configure.ac:51: error: must install xorg-server development files before running autoconf/autogen

over having:

        checking for XORG... no
        configure: error: Package requirements (xorg-server >= 1.6) were not met:

Dan is also of the opinion that it is preferable, but I just can't see
why. In a distro building world perhaps?

One drawback is the m4 test "fails to fail" when the server is
uninstalled after synaptics have been configured as the XORG macro is
cached. The following PKG_CHECK_MODULE will stop on error, however.
Maybe this is the way it should work.

BTW, the randr extension is not optional so this whole test is useless,
but that is a separate discussion :-)

I am taking a hard look at this because when I find something that is
better, I apply it to other modules. This is a lot of work, so I need to
be really sure. 

> 
> -- 
> Diego Elio Pettenò — Flameeyes
> http://blog.flameeyes.eu/
> 
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110614/9db8250e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110614/9db8250e/attachment-0001.pgp>