[PATCH:xfs 3/4] Move os/config.h into os/config.c

Mark Kettenis mark.kettenis at xs4all.nl
Sat Nov 12 02:25:03 PST 2011


> From: Alan Coopersmith <alan.coopersmith at oracle.com>
> Date: Fri, 11 Nov 2011 22:49:09 -0800
> 
> The only file that needed the only remaining definition was config.c,
> so there's no point keeping a header file around for a single #define

Dunno, there is a school of thought that says that (potentially)
tunable #defines like this should live in a header file.  And the fact
that there is only one such #define in the file now doesn't mean that
people wouldn't want to add more in the future.

And there's a downside to this as well, since removing files creates
problems for people importing the source into a different VCS.  I'm
not saying that files should never be removed, but in this case I'd
say your reason for doing so is just a matter of taste.


More information about the xorg-devel mailing list