[PATCH:xfs 3/4] Move os/config.h into os/config.c

Jeremy Huddleston jeremyhu at apple.com
Sat Nov 12 16:49:04 PST 2011


If someone wants to tune that in the future, they can make a configure option for it, so it can live in autoconf's config.h ...

On Nov 12, 2011, at 02:25, Mark Kettenis wrote:

>> From: Alan Coopersmith <alan.coopersmith at oracle.com>
>> Date: Fri, 11 Nov 2011 22:49:09 -0800
>> 
>> The only file that needed the only remaining definition was config.c,
>> so there's no point keeping a header file around for a single #define
> 
> Dunno, there is a school of thought that says that (potentially)
> tunable #defines like this should live in a header file.  And the fact
> that there is only one such #define in the file now doesn't mean that
> people wouldn't want to add more in the future.
> 
> And there's a downside to this as well, since removing files creates
> problems for people importing the source into a different VCS.  I'm
> not saying that files should never be removed, but in this case I'd
> say your reason for doing so is just a matter of taste.
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
> 



More information about the xorg-devel mailing list