[PATCH 1/3] Have FreePixmap call screen hooks, not the other way around.

Jamey Sharp jamey at minilop.net
Mon Oct 3 16:16:29 PDT 2011

On Mon, Oct 03, 2011 at 12:03:33PM +0200, Michel Dänzer wrote:
> On Sam, 2011-10-01 at 23:08 -0700, Jamey Sharp wrote: 
> > In the process, move reference counting into FreePixmap instead of
> > doing it inconsistently in the various screen hooks.
> I like the series, the only minor nit being that the name 'FreePixmap'
> still implies that the pixmap is freed immediately. How about something
> like 'UnreferencePixmap' or an abbreviation thereof?

Good point. Josh suggested ReleasePixmap, which I like. (I try to pick
short words instead of abbreviating long ones.) I've updated my
pixmap-hooks branch with that change, which didn't affect the other two

git://anongit.freedesktop.org/~jamey/xserver pixmap-hooks

Would you like to provide a Reviewed-by now that I've made that change?

Jeremy, can I continue to use your Reviewed-by/Tested-by or would you
like to re-test now? I've tested with xf86-video-nested.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111003/01e0b408/attachment.pgp>

More information about the xorg-devel mailing list