[PATCH 1/3] Have FreePixmap call screen hooks, not the other way around.

Jeremy Huddleston jeremyhu at apple.com
Mon Oct 3 18:53:18 PDT 2011

On Oct 3, 2011, at 4:16 PM, Jamey Sharp wrote:

> On Mon, Oct 03, 2011 at 12:03:33PM +0200, Michel Dänzer wrote:
>> On Sam, 2011-10-01 at 23:08 -0700, Jamey Sharp wrote: 
>>> In the process, move reference counting into FreePixmap instead of
>>> doing it inconsistently in the various screen hooks.
>> I like the series, the only minor nit being that the name 'FreePixmap'
>> still implies that the pixmap is freed immediately. How about something
>> like 'UnreferencePixmap' or an abbreviation thereof?
> Good point. Josh suggested ReleasePixmap, which I like. (I try to pick
> short words instead of abbreviating long ones.) I've updated my
> pixmap-hooks branch with that change, which didn't affect the other two
> patches.
> git://anongit.freedesktop.org/~jamey/xserver pixmap-hooks
> http://cgit.freedesktop.org/~jamey/xserver/log/?h=pixmap-hooks
> Would you like to provide a Reviewed-by now that I've made that change?
> Jeremy, can I continue to use your Reviewed-by/Tested-by or would you
> like to re-test now? I've tested with xf86-video-nested.

My tags remain.  I trust you to change around symbol names without changing functionality ;)

More information about the xorg-devel mailing list