[PULL] build fix, GC clipping cleanup

Aaron Plattner aplattner at nvidia.com
Tue Oct 4 12:47:22 PDT 2011

On 10/04/2011 12:43 PM, Keith Packard wrote:
> * PGP Signed by an unknown key
> On Tue, 4 Oct 2011 12:37:59 -0700, Aaron Plattner<aplattner at nvidia.com>  wrote:
>> With the old CreatePixmap API, drivers could override the width and
>> height when calling down to prevent the fb layer from allocating the
>> pixmap memory, and then plug in its own.  It looks like a driver could
>> do the same thing now by changing the pixmap structure's width and
>> height to 0 temporarily, but it looks like that will cause the new code
>> to call malloc(0) and then fail if it returns NULL.
> Might make sense to have the fb code *not* allocate memory if
> devPrivate.ptr is non-zero?

Oh, you mean have the driver allocate the storage before calling down? 
Yeah, that's a good idea.

-- Aaron

More information about the xorg-devel mailing list