[PATCH] os: Print a newline when Error is called

Peter Hutterer peter.hutterer at who-t.net
Mon Oct 10 19:04:10 PDT 2011


On Mon, Oct 10, 2011 at 06:47:56PM -0700, Jeremy Huddleston wrote:
> 
> On Oct 10, 2011, at 18:24, Peter Hutterer wrote:
> 
> > There are only very few callers. IMO we should replace them with 
> >    ErrorF("%s", strerror(errno)); 
> > and remove this one completely.
> 
> Except that it is exported:
> 
> os.h:extern _X_EXPORT void Error(const char *str);
> 
> How about deprecating it in 1.12 and revisiting for removal in 1.13?

I only have a limited checkout (input drivers + big video drivers) and can't
find a caller. We could remove it now, we're still in the merge window.

Cheers,
  Peter


More information about the xorg-devel mailing list