[PATCH] os: Print a newline when Error is called
alan.coopersmith at oracle.com
Mon Oct 10 19:23:33 PDT 2011
On 10/10/11 07:04 PM, Peter Hutterer wrote:
> On Mon, Oct 10, 2011 at 06:47:56PM -0700, Jeremy Huddleston wrote:
>> On Oct 10, 2011, at 18:24, Peter Hutterer wrote:
>>> There are only very few callers. IMO we should replace them with
>>> ErrorF("%s", strerror(errno));
>>> and remove this one completely.
>> Except that it is exported:
>> os.h:extern _X_EXPORT void Error(const char *str);
>> How about deprecating it in 1.12 and revisiting for removal in 1.13?
> I only have a limited checkout (input drivers + big video drivers) and can't
> find a caller. We could remove it now, we're still in the merge window.
I didn't find any calls in the nm output for my current git-master builds of:
Plus a fairly recent binary package (280.13) of:
-Alan Coopersmith- alan.coopersmith at oracle.com
Oracle Solaris Platform Engineering: X Window System
More information about the xorg-devel