[Pull v2] Glamor - fixed build failure, fixed coding style problem.

Zhigang Gong zhigang.gong at linux.intel.com
Tue Oct 18 02:23:23 PDT 2011

> -----Original Message-----
> From: Jeremy Huddleston [mailto:jeremyhu at apple.com]
> Sent: Tuesday, October 18, 2011 3:56 PM
> To: Zhigang Gong
> Cc: 'Keith Packard'; xorg-devel at lists.x.org
> Subject: Re: [Pull v2] Glamor - fixed build failure, fixed coding style
> problem.
> FWIW, there are a couple conflicts with my pending PULL request, but
> they're trivial to address:
> CONFLICT (content): Merge conflict in include/xorg-config.h.in CONFLICT
> (content): Merge conflict in hw/xfree86/dixmods/Makefile.am
> Your spacing in  hw/xfree86/dixmods/Makefile.am is bad, 
Could you point out where is the bad space? I failed to find it out. Thanks.

> and you're
> missing -module (which should be more obvious that it's necessary when
> my PULL is merged).
I found the other dix modules don't use -module. Shall we add -module for
the dix modules here?  Or just after your pull, we need to add -module for
these dix modules including libfb, libdbe, etc.

> There are hardly any (maybe none?) reviewed-by tags in there, and some
> are missing sign-off tags.  You should really send this to the list for
> before sending a pull request.
emm, I know, so I have been asking comments from the list since about 1
month ago.
I will continue to improve the code according to the comments. Maybe I
should not 
use "Pull" in the topic.
> Also, what about Soren's comment:
> """
> It would make a lot of sense to add hardware acceleration to pixman, since
> that way both X, cairo, and spice could benefit from it. It could be done
> either through GL or by directly talking to the hardware.
> """
> So wouldn't this be better inside of pixman?
Glamor's purpose is to provide a GL based rendering acceleration framework 
which is dedicated for X server. Glamor don't want to provide any generic
to other libraries currently.

I know cairo already has GL backend for application usage, but currently
there is
no easy way to let the xserver to leverage cairo to do the rendering. As to
pixman, IMO, it's a 2D library focus on rasterizing by using CPU only. For
the client 
side application, cairo is a good 2D libraries to utilize GPU hardware
I'm not familiar with spice. Just googled it, and it seems that it's a
protocol to offload
some CPU/GPU intensive tasks to remote client. I think it's also out of
glamor's scope. 

Thanks for your comments.
-- zhigang
> On Oct 18, 2011, at 12:25 AM, Zhigang Gong wrote:
> > Hi Keith,
> >
> > I just came back from a long vacation and I checked all the comments
> > for the glamor's pull request. All the comments came from Alan. Thanks
> Alan.
> > Here are a summary of those comments and current status:
> >
> > 1.  Alan reported a build fail problem.
> > Fixed and tested by Alan.
> > 2.  Alan pointed out that the coding style is not consistent with X's
> > and even have some conflicts with the code itself.
> > Fixed in the latest version. Alan took a quick glance, and said it's
> > more consistent with itself. And after that, I made some change to use
> > camelCase naming rule according to X coding style.
> >
> > Please check it out and if any other thing need to be fixed, please
> > let me know.
> >
> > Thanks.
> >
> > --Zhigang
> >

More information about the xorg-devel mailing list