[PATCH synaptics] Constify priv->device

Daniel Stone daniel at fooishbar.org
Wed Jan 4 11:01:31 PST 2012


On 4 January 2012 18:55, Mark Kettenis <mark.kettenis at xs4all.nl> wrote:
>> X-Original-To: xorg-devel at lists.x.org
>> From: Daniel Stone <daniel at fooishbar.org>
>> Date: Wed,  4 Jan 2012 17:02:30 +0000
>> Fixes a compiler warning due to discarding the const qualifier as it
>> comes back from the option code.
> If Daniel Kurtz's analysis of the problem is right, and I believe it
> is, then this diff is just as wrong as the previous diff from Peter.
> It also means that the real culprit is Peter's change to constify
> XIChangeDeviceProperty().  While Daniel Kurtz's suggestion to
> introduce a cpointer typedef would work, I think it's better to drop
> the pointer typedef entirely and simply use "const void *" in the
> XIChangeDeviceProperty() prototype.  We should probably deprecate the
> pointer typedef; I bet the reason it was introduced was to support
> pre-ANSI C, and I think we all agree that's irrelevant now.

I never saw Daniel's analysis, but even if it's true, we'll need to
fix it somehow for this ABI version anyway, and while the patch may
not be excruciatingly correct per se, it's certainly safe for the

That being said, I wholeheartedly agree with your crusade against
irrelevant compatibility code that just makes everyone's lives harder,
and would happily review any patches to that end. :)


More information about the xorg-devel mailing list