[PATCH synaptics] Constify priv->device
mark.kettenis at xs4all.nl
Wed Jan 4 11:41:25 PST 2012
> Date: Wed, 4 Jan 2012 19:01:31 +0000
> From: Daniel Stone
> > If Daniel Kurtz's analysis of the problem is right, and I believe it
> > is, then this diff is just as wrong as the previous diff from Peter.
> > It also means that the real culprit is Peter's change to constify
> > XIChangeDeviceProperty(). Â While Daniel Kurtz's suggestion to
> > introduce a cpointer typedef would work, I think it's better to drop
> > the pointer typedef entirely and simply use "const void *" in the
> > XIChangeDeviceProperty() prototype. Â We should probably deprecate the
> > pointer typedef; I bet the reason it was introduced was to support
> > pre-ANSI C, and I think we all agree that's irrelevant now.
> I never saw Daniel's analysis,
> but even if it's true, we'll need to fix it somehow for this ABI
> version anyway, and while the patch may not be excruciatingly
> correct per se, it's certainly safe for the usage.
The change I'm suggesting won't affect the ABI in any way.
More information about the xorg-devel