[PATCH 1/2] dix: Return BadWindow rather than BadMatch from dixLookupWindow

Daniel Stone daniel at fooishbar.org
Thu Jan 5 00:55:42 PST 2012


On 5 January 2012 01:22, Christopher James Halse Rogers
<christopher.halse.rogers at canonical.com> wrote:
> dixLookupWindow uses dixLookupDrawable internally, which returns
> BadMatch when the XID matches a non-Window drawable.  Users
> of dixLookupWindow don't care about this, just that it's not
> a valid Window.
> This is a generalised version of the fix for X.Org Bug 23562,
> where GetProperty was incorrectly returning BadMatch. Auditing other
> window requests, all that I checked would incorrectly return BadMatch
> in these circumstances.  An incomplete list of calls that could
> incorrectly return BadMatch is: ListProperties, SetSelectionOwner,
> {Destroy,Map,Unmap}{,Sub}Window.

This also fixes QueryTree.

Reviewed-by: Daniel Stone <daniel at fooishbar.org>

More information about the xorg-devel mailing list