[PATCH 1/2] dix: Return BadWindow rather than BadMatch from dixLookupWindow

Adam Jackson ajax at nwnk.net
Fri Jan 6 11:28:59 PST 2012

On 1/4/12 8:22 PM, Christopher James Halse Rogers wrote:
> dixLookupWindow uses dixLookupDrawable internally, which returns
> BadMatch when the XID matches a non-Window drawable.  Users
> of dixLookupWindow don't care about this, just that it's not
> a valid Window.
> This is a generalised version of the fix for X.Org Bug 23562,
> where GetProperty was incorrectly returning BadMatch. Auditing other
> window requests, all that I checked would incorrectly return BadMatch
> in these circumstances.  An incomplete list of calls that could
> incorrectly return BadMatch is: ListProperties, SetSelectionOwner,
> {Destroy,Map,Unmap}{,Sub}Window.
> None of the callers of dixLookupWindow, except for GetProperty, check
> for BadMatch
> Signed-off-by: Christopher James Halse Rogers<christopher.halse.rogers at canonical.com>

Merged this series into my 1.12 tree.

- ajax

More information about the xorg-devel mailing list