[PATCH] xf86: add rgb ordering helper

Aaron Plattner aplattner at nvidia.com
Thu Jan 26 14:28:42 PST 2012

On 01/26/2012 01:46 PM, Daniel Stone wrote:
> On 26 January 2012 22:36, Dave Airlie<airlied at gmail.com>  wrote:
>> From: Dave Airlie<airlied at redhat.com>
>> At least the intel, nouveau and radeon driver contain this chunk of code.
>> We should move it into the server just for the sake of stopping further cut-n-paste.
>> Drivers can be adapted to use it later.
>> Signed-off-by: Dave Airlie<airlied at redhat.com>
> Can you not drop the ScreenPtr argument and just say that the function
> relies on ScrnInfoPtr::pScreen being valid?

It would presumably be typically called from ScreenInit, where pScrn->pScreen is 

If you want to have the server wire that up earlier, that'd be another matter.

> With that:
> Reviewed-by: Daniel Stone<daniel at fooishbar.org>
> Cheers,
> Daniel

More information about the xorg-devel mailing list