[PATCH] xf86: add rgb ordering helper

Daniel Stone daniel at fooishbar.org
Thu Jan 26 14:32:48 PST 2012


On 27 January 2012 09:28, Aaron Plattner <aplattner at nvidia.com> wrote:
> On 01/26/2012 01:46 PM, Daniel Stone wrote:
>> Can you not drop the ScreenPtr argument and just say that the function
>> relies on ScrnInfoPtr::pScreen being valid?
> It would presumably be typically called from ScreenInit, where
> pScrn->pScreen is NULL.
> If you want to have the server wire that up earlier, that'd be another
> matter.

Rather.  A few drivers (at least radeon, nouveau, and vmware, as well
as the one I just wrote) wire it up during ScreenInit, which I'd
thought was more widespread.  I don't see any downside to doing it in
the server before ScreenInit though.


More information about the xorg-devel mailing list