[PATCH] xf86: add rgb ordering helper

Dave Airlie airlied at gmail.com
Thu Jan 26 23:06:29 PST 2012

On Thu, Jan 26, 2012 at 10:32 PM, Daniel Stone <daniel at fooishbar.org> wrote:
> Hi,
> On 27 January 2012 09:28, Aaron Plattner <aplattner at nvidia.com> wrote:
>> On 01/26/2012 01:46 PM, Daniel Stone wrote:
>>> Can you not drop the ScreenPtr argument and just say that the function
>>> relies on ScrnInfoPtr::pScreen being valid?
>> It would presumably be typically called from ScreenInit, where
>> pScrn->pScreen is NULL.
>> If you want to have the server wire that up earlier, that'd be another
>> matter.
> Rather.  A few drivers (at least radeon, nouveau, and vmware, as well
> as the one I just wrote) wire it up during ScreenInit, which I'd
> thought was more widespread.  I don't see any downside to doing it in
> the server before ScreenInit though.

Yeah thats not the shed I was painting right now.

So we can either change it to passing pScreen, and doing the
xf86Screens[pScreen->myNum] dance, or we can leave as it is.

> Cheers,
> Daniel

More information about the xorg-devel mailing list