[PATCH] xf86: add rgb ordering helper

Dave Airlie airlied at gmail.com
Thu Jan 26 23:08:27 PST 2012

On Thu, Jan 26, 2012 at 9:57 PM, Keith Packard <keithp at keithp.com> wrote:
> On Thu, 26 Jan 2012 11:36:47 +0000, Dave Airlie <airlied at gmail.com> wrote:
>> +void xf86FixupRGBOrdering(ScrnInfoPtr scrn, ScreenPtr screen)
> This name is very misleading; it's filling out visual pixel format
> information, not somehow 'fixing' RGB ordering.

The name is from the comment that is cut-n-pasted in every driver.

/* Fixup RGB ordering */

It makes replacing it in drivers easier to find, but please suggest a
good name and I'll use it, and/or fix the comments in the drivers.


More information about the xorg-devel mailing list