[PATCH] xf86: add rgb ordering helper

Aaron Plattner aplattner at nvidia.com
Thu Jan 26 23:34:30 PST 2012

On 01/26/2012 01:57 PM, Keith Packard wrote:
> * PGP Signed by an unknown key
> On Thu, 26 Jan 2012 11:36:47 +0000, Dave Airlie<airlied at gmail.com>  wrote:
>> +void xf86FixupRGBOrdering(ScrnInfoPtr scrn, ScreenPtr screen)
> This name is very misleading; it's filling out visual pixel format
> information, not somehow 'fixing' RGB ordering.

IIRC, the visuals get a default set of offsets in miInitVisuals that's 
typically backwards for modern hardware.  Hence this code fixes the 
ordering, rather than just initializing it in the first place.

This shed needs to be green.

-- Aaron

More information about the xorg-devel mailing list