[PATCH 09/18] Xfbdev: Treat 1 bpp pseudocolor as monochrome

Geert Uytterhoeven geert at linux-m68k.org
Mon Apr 8 14:01:20 PDT 2013

On Mon, Apr 8, 2013 at 6:55 PM, Keith Packard <keithp at keithp.com> wrote:
> Geert Uytterhoeven <geert at linux-m68k.org> writes:
>> miCreateDefColormap() only preallocates black and white pixels if
>> depth > 1.
> I think you should also set pScreen->whitePixel and pScreen->blackPixel to
> match the MONO01 definitions; it seems like you're taking advantage of
> the behavior of miCreateDefColormap without doing that?

Due to the visual override, fbdevCreateColormap() takes care of that since
"[PATCH 08/18] Xfbdev: Add support for monochrome visuals".



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

More information about the xorg-devel mailing list