[PATCH 09/18] Xfbdev: Treat 1 bpp pseudocolor as monochrome

Keith Packard keithp at keithp.com
Mon Apr 8 15:55:05 PDT 2013

Geert Uytterhoeven <geert at linux-m68k.org> writes:

>> Geert Uytterhoeven <geert at linux-m68k.org> writes:
>>> miCreateDefColormap() only preallocates black and white pixels if
>>> depth > 1.
>> I think you should also set pScreen->whitePixel and pScreen->blackPixel to
>> match the MONO01 definitions; it seems like you're taking advantage of
>> the behavior of miCreateDefColormap without doing that?
> Due to the visual override, fbdevCreateColormap() takes care of that since
> "[PATCH 08/18] Xfbdev: Add support for monochrome visuals".

Indeed. Thanks for checking.

Reviewed-by: Keith Packard <keithp at keithp.com>

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130408/f0fc4695/attachment.pgp>

More information about the xorg-devel mailing list