[PATCH 04/18] Three minor warning and whitespace fixes

Eric Anholt eric at anholt.net
Mon Aug 25 14:04:37 PDT 2014


Keith Packard <keithp at keithp.com> writes:

> Declare a constant string 'const', clean up some indentation whitespace

OK, instead of ad-hoc writing that command every time, I put a script in
~/bin:

anholt at eliezer:xf86-video-intel/src/uxa% git whitespace-vote
tabs: 17202
spaces: 518

anholt at eliezer:xf86-video-intel/src/uxa% git whitespace-vote intel_display.c
tabs: 1278
spaces: 184

So there's a bunch of disagreement between this new code and existing
practice about whitespace, and still misc unrelated whitespace changes
sprinkled into the remaining patches.  That makes me grumpy when
reviewing, but I don't actually care to block things due to that.  This
driver is enough of a disaster already that whitespace inconsistency
isn't its main problem.

Patches 1-3, 5-6, 8, 12-15 are:

Reviewed-by: Eric Anholt <eric at anholt.net>

16-18: I'm still looking at them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140825/e00861a2/attachment.sig>


More information about the xorg-devel mailing list