[PATCH 04/18] Three minor warning and whitespace fixes

Keith Packard keithp at keithp.com
Mon Aug 25 23:03:45 PDT 2014


Eric Anholt <eric at anholt.net> writes:

> So there's a bunch of disagreement between this new code and existing
> practice about whitespace, and still misc unrelated whitespace changes
> sprinkled into the remaining patches.  That makes me grumpy when
> reviewing, but I don't actually care to block things due to that.  This
> driver is enough of a disaster already that whitespace inconsistency
> isn't its main problem.

Yeah, I'm trying to use the server standard settings for all X work
these days, so I'm using spaces instead of tabs. I can fix that if you
want, but as you say, it's just annoyingly inconsistent.

> Patches 1-3, 5-6, 8, 12-15 are:
>
> Reviewed-by: Eric Anholt <eric at anholt.net>

Thanks!

> 16-18: I'm still looking at them.

Cool.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140825/443b3414/attachment.sig>


More information about the xorg-devel mailing list