[PATCH v2 1/5] present: If present_queue_vblank() fails, do present_execute().

Keith Packard keithp at keithp.com
Thu Dec 18 19:33:33 PST 2014


Kenneth Graunke <kenneth at whitecape.org> writes:

> Previously, if present_queue_vblank() failed, we simply dropped the
> present request on the floor, and returned an error.  This was rather
> mean to clients - after presenting, they wait for a PresentComplete
> event to come back.  But since the present never happens, they end up
> waiting forever, and lock up in poll().
>
> This patch falls back to present_execute if present_queue_vblank fails.
> We still print a debugging message to warn when queueing fails, which
> allows us to continue debugging problems, but makes Present robust
> enough to not lock up people's compositing manager when vblank bugs
> happen.
>
> v2: Don't do present_queue_vblank() /and/ present_execute() (a bug that
>     snuck in during last minute tidying).

With this replacement for the previous patch, the whole series is

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20141218/6a4f1e17/attachment.sig>


More information about the xorg-devel mailing list