[PATCH v2 1/5] present: If present_queue_vblank() fails, do present_execute().

Jason Ekstrand jason at jlekstrand.net
Fri Dec 19 08:17:29 PST 2014


It's been working for me since last night and has even survived sleeping a
couple of times.

Tested-by: Jason Ekstrand <jason.ekstrand at intel.com>

On Thu, Dec 18, 2014 at 7:33 PM, Keith Packard <keithp at keithp.com> wrote:
>
> Kenneth Graunke <kenneth at whitecape.org> writes:
>
> > Previously, if present_queue_vblank() failed, we simply dropped the
> > present request on the floor, and returned an error.  This was rather
> > mean to clients - after presenting, they wait for a PresentComplete
> > event to come back.  But since the present never happens, they end up
> > waiting forever, and lock up in poll().
> >
> > This patch falls back to present_execute if present_queue_vblank fails.
> > We still print a debugging message to warn when queueing fails, which
> > allows us to continue debugging problems, but makes Present robust
> > enough to not lock up people's compositing manager when vblank bugs
> > happen.
> >
> > v2: Don't do present_queue_vblank() /and/ present_execute() (a bug that
> >     snuck in during last minute tidying).
>
> With this replacement for the previous patch, the whole series is
>
> Reviewed-by: Keith Packard <keithp at keithp.com>
>
> --
> keith.packard at intel.com
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20141219/dd01735c/attachment.html>


More information about the xorg-devel mailing list