[PATCH v2 0/2] Fix ODEV_ATTRIB_DRIVER overlapping with ODEV_ATTRIB_FD

Keith Packard keithp at keithp.com
Mon Jul 14 16:19:26 PDT 2014

Hans de Goede <hdegoede at redhat.com> writes:

> Note the robustness patch needs to be applied after the fix, otherwise
> the switch-case in the fix will fail to compile due to a duplicate
> label.

This is better than my version as it effectively types the values
explicitly. Thanks!

Reviewed-by: Keith Packard <keithp at keithp.com>

   9a19bf0..4dbb641  master -> master

I've spent a few minutes this morning reworking the OdevAttributes stuff
to just store the values in a struct; this results in compile-time
typechecking of values and about 200 lines less code. This isn't going
into 1.16, but can land immediately afterwards, once reviewed.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-config-Replace-OdevAttributes-linked-list-with-struc.patch
Type: text/x-diff
Size: 20434 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140714/b6730969/attachment.patch>
-------------- next part --------------

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140714/b6730969/attachment.sig>

More information about the xorg-devel mailing list