[PATCH v2 0/2] Fix ODEV_ATTRIB_DRIVER overlapping with ODEV_ATTRIB_FD

Hans de Goede hdegoede at redhat.com
Tue Jul 15 00:21:08 PDT 2014


On 07/15/2014 01:19 AM, Keith Packard wrote:
> Hans de Goede <hdegoede at redhat.com> writes:
>> Note the robustness patch needs to be applied after the fix, otherwise
>> the switch-case in the fix will fail to compile due to a duplicate
>> label.
> This is better than my version as it effectively types the values
> explicitly. Thanks!

You're welcome.

> Reviewed-by: Keith Packard <keithp at keithp.com>
> Merged.
>    9a19bf0..4dbb641  master -> master


> I've spent a few minutes this morning reworking the OdevAttributes stuff
> to just store the values in a struct; this results in compile-time
> typechecking of values and about 200 lines less code. This isn't going
> into 1.16, but can land immediately afterwards, once reviewed.

Hmm, I'm not sure I like this change. I can see it is a nice cleanup,
but there are 2 things about it I don't like:

1) I was not around when the OdevAttributes stuff got added, but I
think the idea behind it was to be able to add new atrributes without
breaking ABI (as was done this cycle when adding the driver string,
although that needed a bit of a fixup).

2) It will require some ugly #ifdef-ery in almost all the drivers to work
with both the old and the new way.



More information about the xorg-devel mailing list