[PATCH 00/12] Rework intel 2D driver glamor support

Keith Packard keithp at keithp.com
Wed Jul 30 23:56:12 PDT 2014

Eric Anholt <eric at anholt.net> writes:

> Keith Packard <keithp at keithp.com> writes:
>> I spent the day just cleaning up this patch series and testing. I
>> think it's ready for others to use and review. I've been running it on
>> two machines for a couple of days now and it's been solid.
> Patches 2, 4 are:
> Reviewed-by: Eric Anholt <eric at anholt.net>
> Patch 5 is:
> Acked-by: Eric Anholt <eric at anholt.net>

I've pushed a new version of the tree with your review marked and a few

 * Split the GetScratchPixmapHeader change into two pieces; the first
   just removes the redundant calls to drm_intel_bo_disable_reuse and
   the second contains the scratch pixmap changes and the other misc
   stuff. Yes, I could split the misc changes out into another cleanup
   patch if you want.

 * Removed the tiling check from intel_present when flipping. The kernel
   doesn't appear to ever require matching tiling.

 * Removed call to dixPrivateKeyRegistered in the 'Add glamor back' patch.

What I didn't do is clean up the 'remove glamor' patch so that it would
compile even with --enable-glamor. Fixing that seems like noise to me;
all of the changes needed to make it work would be immediately un-done
when adding glamor back.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140730/99ae044c/attachment.sig>

More information about the xorg-devel mailing list