[PATCH 1/4] fb: fix screen pixmap leak on server reset

Keith Packard keithp at keithp.com
Thu Jun 26 14:15:41 PDT 2014


Julien Cristau <jcristau at debian.org> writes:

> This breaks Xvfb:
> https://bugs.freedesktop.org/show_bug.cgi?id=80313
>
> pScreen->devPrivate is NULL, so we crash trying to dereference it in
> FreePixmap(), whereas the free() was a no-op.

How about we have fb check pScreen->devPrivate != NULL before calling
FreePixmap?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fb-Don-t-free-NULL-pixmap-in-fbCloseScreen.-Bug-8031.patch
Type: text/x-diff
Size: 1055 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140626/35d0f013/attachment.patch>
-------------- next part --------------

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140626/35d0f013/attachment.sig>


More information about the xorg-devel mailing list