[PATCH 1/4] fb: fix screen pixmap leak on server reset
airlied at gmail.com
Thu Jun 26 14:20:13 PDT 2014
On 27 June 2014 07:15, Keith Packard <keithp at keithp.com> wrote:
> Julien Cristau <jcristau at debian.org> writes:
>> This breaks Xvfb:
>> pScreen->devPrivate is NULL, so we crash trying to dereference it in
>> FreePixmap(), whereas the free() was a no-op.
> How about we have fb check pScreen->devPrivate != NULL before calling
is pScreen->devPrivate guaranteed to be a pixmap, or is that just a convention?
Do we have anything to say when it is?
I think I'm also confusing this with the screwed up miScreenInit
private ptr hiding stuff.
More information about the xorg-devel