[PATCH 1/4] fb: fix screen pixmap leak on server reset

[Dave Airlie]

On 27 June 2014 07:15, Keith Packard <keithp at keithp.com> wrote:
> Julien Cristau <jcristau at debian.org> writes:
>
>> This breaks Xvfb:
>> https://bugs.freedesktop.org/show_bug.cgi?id=80313
>>
>> pScreen->devPrivate is NULL, so we crash trying to dereference it in
>> FreePixmap(), whereas the free() was a no-op.
>
> How about we have fb check pScreen->devPrivate != NULL before calling
> FreePixmap?

is pScreen->devPrivate guaranteed to be a pixmap, or is that just a convention?

Do we have anything to say when it is?

I think I'm also confusing this with the screwed up miScreenInit
private ptr hiding stuff.

Dave.