[PATCH 1/4] fb: fix screen pixmap leak on server reset
keithp at keithp.com
Thu Jun 26 15:09:55 PDT 2014
Dave Airlie <airlied at gmail.com> writes:
> is pScreen->devPrivate guaranteed to be a pixmap, or is that just a
It's always a pixmap if you use fb:
#define fbGetScreenPixmap(s) ((PixmapPtr) (s)->devPrivate)
> Do we have anything to say when it is?
A driver *not* using fb could put something else there. I think we
should probably just declare a PixmapPtr in the screen and be done with
> I think I'm also confusing this with the screwed up miScreenInit
> private ptr hiding stuff.
Agreed. We should just create a new structure to pass the screen init
stuff through instead of re-purposing devPrivate.
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 810 bytes
Desc: not available
More information about the xorg-devel