[PATCH 4/6] fb: Avoid installing terminal functions over pre-existing call chains

Keith Packard keithp at keithp.com
Wed May 28 01:31:50 PDT 2014

Chris Wilson <chris at chris-wilson.co.uk> writes:

> The fbWindow family of functions (Map, Unmap, Position and Destroy) are
> all terminal functions, that is they do not chain up to earlier
> extensions. This breaks those chains which leads to not only resource
> leaks but also dereference of dangling pointers. One such issue arises
> with fbScreenInit() breaking the earlier present_screen_init() and
> causing the Xserver to die when a Window is closed after being used with
> Present and fb:

fb expects to be initialized first, before any extensions, so that its
terminal functions will always be at the bottom of the call chain.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140528/72b1c333/attachment.sig>

More information about the xorg-devel mailing list