[PATCH 4/6] fb: Avoid installing terminal functions over pre-existing call chains

Chris Wilson chris at chris-wilson.co.uk
Wed May 28 01:45:35 PDT 2014

On Wed, May 28, 2014 at 01:31:50AM -0700, Keith Packard wrote:
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> > The fbWindow family of functions (Map, Unmap, Position and Destroy) are
> > all terminal functions, that is they do not chain up to earlier
> > extensions. This breaks those chains which leads to not only resource
> > leaks but also dereference of dangling pointers. One such issue arises
> > with fbScreenInit() breaking the earlier present_screen_init() and
> > causing the Xserver to die when a Window is closed after being used with
> > Present and fb:
> fb expects to be initialized first, before any extensions, so that its
> terminal functions will always be at the bottom of the call chain.

Hmm, the sequence I have in UXA is wrong then.

Chris Wilson, Intel Open Source Technology Centre

More information about the xorg-devel mailing list