[PATCH xserver 4/8] Create a threaded mechanism for input [v3]

[Emil Velikov]

On 9 December 2015 at 23:12, Keith Packard <keithp at keithp.com> wrote:

> --- a/dix/main.c
> +++ b/dix/main.c
> @@ -121,12 +121,9 @@ Equipment Corporation.
>  extern void Dispatch(void);
>
>  #ifdef XQUARTZ
> -#include <pthread.h>
> -
> -BOOL serverRunning = FALSE;
> +Bool serverRunning;
Deliberate change ? The declaration in the headers is still using BOOL.

> --- a/include/input.h
> +++ b/include/input.h

> @@ -712,13 +713,37 @@ extern _X_HIDDEN void input_constrain_cursor(DeviceIntPtr pDev, ScreenPtr screen
>                                               int *out_x, int *out_y,
>                                               int *nevents, InternalEvent* events);
>
> +extern _X_EXPORT pthread_mutex_t input_mutex;
> +extern _X_EXPORT __thread int input_mutex_count;
> +
Are these really meant to be exported - a wild guess will be that the
input drivers won't need access to these ?

Mildly related: any particular reason why xserver uses three different
naming formats for its exported symbols - SymbolName, symbolName and
symbol_name ?

Thanks
Emil