[PATCH xserver 4/8] Create a threaded mechanism for input [v3]

[Keith Packard]

Emil Velikov <emil.l.velikov at gmail.com> writes:

>> -BOOL serverRunning = FALSE;
>> +Bool serverRunning;
> Deliberate change ? The declaration in the headers is still using BOOL.

Oops. So many edits; I thought for a while that we'd want to use this
code to make the input thread wait for the server.

>> +extern _X_EXPORT pthread_mutex_t input_mutex;
>> +extern _X_EXPORT __thread int input_mutex_count;
>> +
> Are these really meant to be exported - a wild guess will be that the
> input drivers won't need access to these ?

Turns out they do - evdev needs to grab the input lock to handle button
emulation via a timer.

> Mildly related: any particular reason why xserver uses three different
> naming formats for its exported symbols - SymbolName, symbolName and
> symbol_name ?

Yeah, the nice thing about naming conventions is that you can pick a new
one every couple of years.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20151209/c8cd1ffb/attachment.sig>