[PATCH xserver] glamor: Handle bitplane in glamor_copy_fbo_cpu

Michel Dänzer michel at daenzer.net
Mon Aug 15 09:44:09 UTC 2016

On 19.07.2016 02:49, Adam Jackson wrote:
> On Tue, 2016-07-12 at 12:39 +0900, Michel Dänzer wrote:
>> From: Michel Dänzer <michel.daenzer at amd.com>
>> This can significantly speed up at least some CopyPlane cases, e.g.
>> indirectly for stippled fills.
>> Reported-by: Keith Raghubar <keith.raghubar at amd.com>
>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
>> ---
>> The x/yoff deltas for fbCopyXtoX might be backwards, somebody please check.
> If you mean of the temporary I'm not sure it matters. It's a fresh
> pixmap, ->drawable.[xy] are going to be zero.
> That said this produces visibly different results with Xephyr+glamor
> and x11perf -copyplane10 (compared to fb), so I'm pretty sure something
> about it is wrong.

Indeed, thanks, fixed in v2.

Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

More information about the xorg-devel mailing list