[PATCH] xfree86: vgaarb: Initialize local variable rsrc_decodes

Adam Jackson ajax at nwnk.net
Mon Aug 15 16:35:24 UTC 2016


On Mon, 2016-07-25 at 18:01 +0900, Michel Dänzer wrote:
> On 25.07.2016 17:12, Emily Deng wrote:
> > In function xf86VGAarbiterScrnInit when the "pEnt->bus.type" is
> > BUS_PLATFORM, the "pScrn->vgaDev" won't be set, so the "pScrn->vgaDev" is
> > equal to zero.
> > 
> > The variable "rsrc_decodes" in function "xf86VGAarbiterAllowDRI" is not
> > initialized. So it will occur error when "pScrn->vgaDev == 0", and
> > "vga_count > 1". For this case, as "pScrn->vgaDev == 0", the function
> > "pci_device_vgaarb_get_info" will only set the value of "vga_count",
> > but won't set the value of "rsrc_decodes", so it will has two different
> > return values for function "xf86VGAarbiterAllowDRI" in different
> > platforms. One platform will return TRUE, as the "rsrc_decodes" 's
> > default value is 0, but another platform will return FALSE, as the
> > "rsrc_decodes" 's default value is "32767", this will cause disable
> > direct rendering.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96937
> > 
> > Signed-off-by: Emily Deng <Emily.Deng at amd.com>
> > 
> Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>

remote: I: patch #100736 updated using rev 88820f1c7b66cbc98d3f19efca24c9f52410d9f9.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   fa2bc06..88820f1  master -> master

- ajax


More information about the xorg-devel mailing list