[PATCH xserver] test: Remember to swap the window argument to XIQueryPointer

Adam Jackson ajax at redhat.com
Wed Aug 17 14:43:27 UTC 2016

Before 5c69cb60 this wouldn't matter, because ProcXIQueryPointer
manually emitted its own error before (bogusly) returning Success to the
main loop. Since these tests only look at the return value of the
dispatch function we'd think things succeeded even when we'd generated
an error.

With that fixed, the test code's failure to swap the window id would
make dixLookupWindow (rightly) throw BadWindow.

Signed-off-by: Adam Jackson <ajax at redhat.com>
 test/xi2/protocol-xiquerypointer.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/test/xi2/protocol-xiquerypointer.c b/test/xi2/protocol-xiquerypointer.c
index c0421f6..2bf18fa 100644
--- a/test/xi2/protocol-xiquerypointer.c
+++ b/test/xi2/protocol-xiquerypointer.c
@@ -140,6 +140,7 @@ request_XIQueryPointer(ClientPtr client, xXIQueryPointerReq * req, int error)
     client_request.swapped = TRUE;
+    swapl(&req->win);
     rc = SProcXIQueryPointer(&client_request);
     assert(rc == error);

More information about the xorg-devel mailing list