[PATCH xserver] test: Remember to swap the window argument to XIQueryPointer

Michel Dänzer michel at daenzer.net
Wed Aug 17 14:57:34 UTC 2016


On 17/08/16 11:43 PM, Adam Jackson wrote:
> Before 5c69cb60 this wouldn't matter, because ProcXIQueryPointer
> manually emitted its own error before (bogusly) returning Success to the
> main loop. Since these tests only look at the return value of the
> dispatch function we'd think things succeeded even when we'd generated
> an error.
> 
> With that fixed, the test code's failure to swap the window id would
> make dixLookupWindow (rightly) throw BadWindow.
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>

Reviewed-and-Tested-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the xorg-devel mailing list