[PATCH xserver] test: Remember to swap the window argument to XIQueryPointer

Adam Jackson ajax at redhat.com
Wed Aug 17 15:05:33 UTC 2016


On Wed, 2016-08-17 at 23:57 +0900, Michel Dänzer wrote:
> On 17/08/16 11:43 PM, Adam Jackson wrote:
> > 
> > Before 5c69cb60 this wouldn't matter, because ProcXIQueryPointer
> > manually emitted its own error before (bogusly) returning Success to the
> > main loop. Since these tests only look at the return value of the
> > dispatch function we'd think things succeeded even when we'd generated
> > an error.
> > 
> > With that fixed, the test code's failure to swap the window id would
> > make dixLookupWindow (rightly) throw BadWindow.
> > 
> > Signed-off-by: Adam Jackson <ajax at redhat.com>
> 
> Reviewed-and-Tested-by: Michel Dänzer <michel.daenzer at amd.com>

Merged (and my pre-push hook actually ran this time!):

remote: I: patch #105654 updated using rev 6acd0d098add5a14f23d326ac6ee8cebab14b86a.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   5c69cb6..6acd0d0  master -> master

- ajax


More information about the xorg-devel mailing list