[PATCH kdrive/evdev] kdrive/evdev: update keyboard LEDs (#22302)

Adam Jackson ajax at nwnk.net
Mon Feb 22 18:48:28 UTC 2016

On Mon, 2016-02-15 at 11:32 -0200, Laércio de Sousa wrote:

> Implement missing parts in kdrive evdev driver for
> correct update of evdev keyboard LEDs.

Hah! I like how this was there and just not wired up.

> +    if (!ke) {
> +        ErrorF("Can't update LEDs of disabled evdev keyboard %s.\n", ki->path);
> +        return;
> +    }

I'm not a fan of error messages for routine conditions. If this is
really a "shouldn't happen" case then fine, but it looks like this will
emit a message every time you have >=1 disabled keyboards and hit
CapsLock on an enabled keyboard. If I'm reading that correctly, can we
just drop this message?

- ajax

More information about the xorg-devel mailing list