[PATCH kdrive/evdev] kdrive/evdev: update keyboard LEDs (#22302)

[Laércio de Sousa]

Ah, yes! No problem! We can drop it.

2016-02-22 15:48 GMT-03:00 Adam Jackson <ajax at nwnk.net>:

> On Mon, 2016-02-15 at 11:32 -0200, Laércio de Sousa wrote:
>
> > Implement missing parts in kdrive evdev driver for
> > correct update of evdev keyboard LEDs.
>
> Hah! I like how this was there and just not wired up.
>
> > +    if (!ke) {
> > +        ErrorF("Can't update LEDs of disabled evdev keyboard %s.\n",
> ki->path);
> > +        return;
> > +    }
>
> I'm not a fan of error messages for routine conditions. If this is
> really a "shouldn't happen" case then fine, but it looks like this will
> emit a message every time you have >=1 disabled keyboards and hit
> CapsLock on an enabled keyboard. If I'm reading that correctly, can we
> just drop this message?
>
> - ajax
>



-- 
*Laércio de Sousa*
*Orientador de Informática*
*Escola Municipal "Professor Eulálio Gruppi"*
*Rua Ismael da Silva Mello, 559, Mogi Moderno*
*Mogi das Cruzes - SPCEP 08717-390*
Telefone: (11) 4726-8313
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160222/f4a5384b/attachment.html>