[PATCH xserver 1/5] xfree86/modes: Refactor xf86_use_hw_cursor_argb to use xf86_use_hw_cursor

[Michel Dänzer]

On 09.03.2016 12:46, Keith Packard wrote:
> Michel Dänzer <michel at daenzer.net> writes:
> 
>> Unfortunately, the reality is that at least the radeon and amdgpu
>> drivers do use it.
> 
> Even modesetting uses it; there isn't any other public interface to get
> the current cursor.
> 
> What do you think about eliminating the RefCursor/FreeCursor bits and
> just letting the upper layer hold the reference?

Sounds good to me.

One thing that might be nice to do as part of your patch would be moving
the xf86_config->cursor = NULL assignment from xf86_cursors_init to
xf86_hide_cursors. That way xf86_config->cursor would always be NULL
while the cursor layer isn't using the hardware cursor.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer