[PATCH xserver 1/5] xfree86/modes: Refactor xf86_use_hw_cursor_argb to use xf86_use_hw_cursor

Keith Packard keithp at keithp.com
Wed Mar 9 19:44:02 UTC 2016


Michel Dänzer <michel at daenzer.net> writes:

> Sounds good to me.
>
> One thing that might be nice to do as part of your patch would be moving
> the xf86_config->cursor = NULL assignment from xf86_cursors_init to
> xf86_hide_cursors. That way xf86_config->cursor would always be NULL
> while the cursor layer isn't using the hardware cursor.

HideCursor gets called when setting the cursor image if
HARDWARE_CURSOR_UPDATE_UNHIDDEN isn't set, which means we'd have to save
the pointer in the LoadCursorImageCheck and LoadCursorARGBCheck
functions.

The LoadCursorImageCheck function doesn't get the CursorPtr.  So, we
need the xf86CurrentCursor function that I had written before.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-xfree86-Set-xf86CrtcConfigRec-cursor-pointer-to-NULL.patch
Type: text/x-diff
Size: 5291 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160309/21697a4a/attachment-0001.patch>
-------------- next part --------------

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160309/21697a4a/attachment-0001.sig>


More information about the xorg-devel mailing list